[ 
https://issues.apache.org/jira/browse/SPARK-16960?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15412695#comment-15412695
 ] 

Apache Spark commented on SPARK-16960:
--------------------------------------

User 'HyukjinKwon' has created a pull request for this issue:
https://github.com/apache/spark/pull/14538

> Deprecate approxCountDistinct, toDegrees and toRadians according to 
> FunctionRegistry in Scala and Python
> --------------------------------------------------------------------------------------------------------
>
>                 Key: SPARK-16960
>                 URL: https://issues.apache.org/jira/browse/SPARK-16960
>             Project: Spark
>          Issue Type: Improvement
>          Components: SQL
>    Affects Versions: 2.0.0
>            Reporter: Hyukjin Kwon
>            Priority: Minor
>
> It seems {{approxCountDistinct}}, {{toDegrees}} and {{toRadians}} are also 
> missed while matching the names to the ones in {{FunctionRegistry}}. (please 
> see 
> [approx_count_distinct|https://github.com/apache/spark/blob/5c2ae79bfcf448d8dc9217efafa1409997c739de/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala#L244],
>  
> [degrees|https://github.com/apache/spark/blob/5c2ae79bfcf448d8dc9217efafa1409997c739de/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala#L203]
>  and 
> [radians|https://github.com/apache/spark/blob/5c2ae79bfcf448d8dc9217efafa1409997c739de/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala#L222]
>  in `FunctionRegistry`).
> I took a scan between {{functions.scala}} and {{FunctionRegistry}} and it 
> seems these are all left. For {{countDistinct}} and {{sumDistinct}}, they are 
> not registered in {{FunctionRegistry}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org

Reply via email to