[ 
https://issues.apache.org/jira/browse/SPARK-16808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15627706#comment-15627706
 ] 

Vinayak Joshi commented on SPARK-16808:
---------------------------------------

The same issue also affects the case where "spark.ui.proxyBase" is set and it 
does not get honored in HistoryServer 2.0. 

This is a regression in 2.0 from 1.6. 

In 2.0, the refactoring of HistoryPage.scala changed the History application 
listing to occur from an ajax call. The page listing is rendered using 
ui/static/historypage-template.html which does not take into account the 
"spark.ui.proxyBase" / APPLICATION_WEB_PROXYBASE when generating the links to 
the applications.

The existing History Server test suite 
-spark/deploy/history/HistoryServerSuite.scala has an explicit test case to 
validate this scenario: "relative links are prefixed with uiRoot 
(spark.ui.proxyBase)"  - but this test case is broken too because the html it's 
receiving and validating no longer contains any application links (as noted 
earlier, they are now generated through a js ajax call etc which does not 
happen in this test) - so even though the test case passes, it's failing it's 
purpose. 

> History Server main page does not honor APPLICATION_WEB_PROXY_BASE
> ------------------------------------------------------------------
>
>                 Key: SPARK-16808
>                 URL: https://issues.apache.org/jira/browse/SPARK-16808
>             Project: Spark
>          Issue Type: Bug
>    Affects Versions: 2.0.0
>            Reporter: Michael Gummelt
>
> The root of the history server is rendered dynamically with javascript, and 
> this doesn't honor APPLICATION_WEB_PROXY_BASE: 
> https://github.com/apache/spark/blob/master/core/src/main/resources/org/apache/spark/ui/static/historypage-template.html#L67
> Other links in the history server do honor it: 
> https://github.com/apache/spark/blob/master/core/src/main/scala/org/apache/spark/ui/UIUtils.scala#L146
> This means the links on the history server root page are broken when deployed 
> behind a proxy.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org

Reply via email to