[ https://issues.apache.org/jira/browse/SPARK-18742?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Song Jun updated SPARK-18742: ----------------------------- Description: After SPARK-12588 Remove HTTPBroadcast [1], the one and only implementation of BroadcastFactory is TorrentBroadcastFactory and the spark.broadcast.factory conf has removed. however the scaladoc says [2]: /** * An interface for all the broadcast implementations in Spark (to allow * multiple broadcast implementations). SparkContext uses a user-specified * BroadcastFactory implementation to instantiate a particular broadcast for the * entire Spark job. */ so we should modify the comment that SparkContext will not use a user-specified BroadcastFactory implementation [1] https://issues.apache.org/jira/browse/SPARK-12588 [2] https://github.com/apache/spark/blob/master/core/src/main/scala/org/apache/spark/broadcast/BroadcastFactory.scala#L25-L30 was: After SPARK-12588 Remove HTTPBroadcast [1], the one and only implementation of BroadcastFactory is TorrentBroadcastFactory. however the scaladoc says [2]: /** * An interface for all the broadcast implementations in Spark (to allow * multiple broadcast implementations). SparkContext uses a user-specified * BroadcastFactory implementation to instantiate a particular broadcast for the * entire Spark job. */ so we should modify the comment that SparkContext will not use a user-specified BroadcastFactory implementation [1] https://issues.apache.org/jira/browse/SPARK-12588 [2] https://github.com/apache/spark/blob/master/core/src/main/scala/org/apache/spark/broadcast/BroadcastFactory.scala#L25-L30 > Clarify that user-defined BroadcastFactory is not supported > ----------------------------------------------------------- > > Key: SPARK-18742 > URL: https://issues.apache.org/jira/browse/SPARK-18742 > Project: Spark > Issue Type: Improvement > Components: Documentation > Reporter: Song Jun > Priority: Trivial > > After SPARK-12588 Remove HTTPBroadcast [1], the one and only implementation > of BroadcastFactory is TorrentBroadcastFactory and the > spark.broadcast.factory conf has removed. > however the scaladoc says [2]: > /** > * An interface for all the broadcast implementations in Spark (to allow > * multiple broadcast implementations). SparkContext uses a user-specified > * BroadcastFactory implementation to instantiate a particular broadcast for > the > * entire Spark job. > */ > so we should modify the comment that SparkContext will not use a > user-specified BroadcastFactory implementation > [1] https://issues.apache.org/jira/browse/SPARK-12588 > [2] > https://github.com/apache/spark/blob/master/core/src/main/scala/org/apache/spark/broadcast/BroadcastFactory.scala#L25-L30 -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org For additional commands, e-mail: issues-h...@spark.apache.org