[ 
https://issues.apache.org/jira/browse/SPARK-16920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15806575#comment-15806575
 ] 

Apache Spark commented on SPARK-16920:
--------------------------------------

User 'mhmoudr' has created a pull request for this issue:
https://github.com/apache/spark/pull/16495

> Investigate and fix issues introduced in SPARK-15858
> ----------------------------------------------------
>
>                 Key: SPARK-16920
>                 URL: https://issues.apache.org/jira/browse/SPARK-16920
>             Project: Spark
>          Issue Type: Improvement
>          Components: MLlib
>            Reporter: Vladimir Feinberg
>
> There were several issues regarding the PR resolving SPARK-15858, my comments 
> are available here:
> https://github.com/apache/spark/commit/393db655c3c43155305fbba1b2f8c48a95f18d93
> The two most important issues are:
> 1. The PR did not add a stress test proving it resolved the issue it was 
> supposed to (though I have no doubt the optimization made is indeed correct).
> 2. The PR introduced quadratic prediction time in terms of the number of 
> trees, which was previously linear. This issue needs to be investigated for 
> whether it causes problems for large numbers of trees (say, 1000), an 
> appropriate test should be added, and then fixed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org

Reply via email to