[
https://issues.apache.org/jira/browse/SPARK-20180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15953240#comment-15953240
]
Sean Owen commented on SPARK-20180:
-----------------------------------
Surely, the impact is more than an 'if' statement. If you contemplate much
larger spans that's going to take longer to compute and return right? I think
we're not at all in agreement there, especially as you're seeing the test (?)
run forever.
Yes I know there's a TODO (BTW you can see who wrote it with 'blame') but that
doesn't mean I agree with it. It also doesn't say it should be a default.
Keep in mind how much time it takes to discuss these changes relative to the
value. We need to converge rapidly to decisions. The question here is
performance impact on non-trivial examples. So far I just don't see much
compelling reason to change a default. The functionality you want is already
available.
> Add a special value for unlimited max pattern length in Prefix span, and set
> it as default.
> -------------------------------------------------------------------------------------------
>
> Key: SPARK-20180
> URL: https://issues.apache.org/jira/browse/SPARK-20180
> Project: Spark
> Issue Type: Improvement
> Components: MLlib
> Affects Versions: 2.1.0
> Reporter: Cyril de Vogelaere
> Priority: Minor
> Original Estimate: 0h
> Remaining Estimate: 0h
>
> Right now, we need to use .setMaxPatternLength() method to
> specify is the maximum pattern length of a sequence. Any pattern longer than
> that won't be outputted.
> The current default maxPatternlength value being 10.
> This should be changed so that with input 0, all pattern of any length would
> be outputted. Additionally, the default value should be changed to 0, so that
> a new user could find all patterns in his dataset without looking at this
> parameter.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
