[ https://issues.apache.org/jira/browse/SPARK-20203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15954904#comment-15954904 ]
Nick Pentreath commented on SPARK-20203: ---------------------------------------- I see there is a comment in the code that says: {{// TODO: support unbounded pattern length when maxPatternLength = 0}}. But the same thing can essentially be achieved setting the pattern length to {{Int.MaxValue}} as Sean has previously said, so I don't really think this is a valid work item (in fact probably that comment should be removed). Is an unbounded default really better (or worse) from an API / user facing perspective? There are arguments either way but to be honest I see nothing compelling enough to warrant a change here. > Change default maxPatternLength value to Int.MaxValue in PrefixSpan > ------------------------------------------------------------------- > > Key: SPARK-20203 > URL: https://issues.apache.org/jira/browse/SPARK-20203 > Project: Spark > Issue Type: Wish > Components: MLlib > Affects Versions: 2.1.0 > Reporter: Cyril de Vogelaere > Priority: Trivial > Original Estimate: 0h > Remaining Estimate: 0h > > I think changing the default value to Int.MaxValue would be more user > friendly. At least for new users. > Personally, when I run an algorithm, I expect it to find all solution by > default. And a limited number of them, when I set the parameters to do so. > The current implementation limit the length of solution patterns to 10. > Thus preventing all solution to be printed when running slightly large > datasets. > I feel like that should be changed, but since this would change the default > behavior of PrefixSpan. I think asking for the communities opinion should > come first. So, what do you think ? -- This message was sent by Atlassian JIRA (v6.3.15#6346) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org For additional commands, e-mail: issues-h...@spark.apache.org