[
https://issues.apache.org/jira/browse/SPARK-20391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15975062#comment-15975062
]
Imran Rashid commented on SPARK-20391:
--------------------------------------
bq. If we want to change the names of the other 2 we could simply add 2 extra
fields with a more appropriate name and leave the other 2 not sure that is
necessary at this point though.
My proposal was to add 2 extra fields which duplicate the existing ones, so
that the memory metrics are together and hopefully the meaning is clear.
{{totalManagedMemory}} would be the same as {{maxMemory}};
{{usedStorageMemory}} would be the same as {{memoryUsed}}. But I'm not super
firm on that, and its definitely not "must do" for 2.2.
bq. It think we should document rest api better
yeah, no objections to better docs, I just see that as a bigger change, and I
think I'd rather update the names for 2.2
bq. I assume managed memory here is spark.memory.fraction on heap +
spark.memory.offHeap.size?
yes.
[~jerryshao] I'm going to mark this as a blocker for 2.2, I think tom and I
basically agree on what needs to be done immediately here. Can you take care
of the implementation?
> Properly rename the memory related fields in ExecutorSummary REST API
> ---------------------------------------------------------------------
>
> Key: SPARK-20391
> URL: https://issues.apache.org/jira/browse/SPARK-20391
> Project: Spark
> Issue Type: Improvement
> Components: Spark Core
> Affects Versions: 2.2.0
> Reporter: Saisai Shao
> Priority: Minor
>
> Currently in Spark we could get executor summary through REST API
> {{/api/v1/applications/<app-id>/executors}}. The format of executor summary
> is:
> {code}
> class ExecutorSummary private[spark](
> val id: String,
> val hostPort: String,
> val isActive: Boolean,
> val rddBlocks: Int,
> val memoryUsed: Long,
> val diskUsed: Long,
> val totalCores: Int,
> val maxTasks: Int,
> val activeTasks: Int,
> val failedTasks: Int,
> val completedTasks: Int,
> val totalTasks: Int,
> val totalDuration: Long,
> val totalGCTime: Long,
> val totalInputBytes: Long,
> val totalShuffleRead: Long,
> val totalShuffleWrite: Long,
> val isBlacklisted: Boolean,
> val maxMemory: Long,
> val executorLogs: Map[String, String],
> val onHeapMemoryUsed: Option[Long],
> val offHeapMemoryUsed: Option[Long],
> val maxOnHeapMemory: Option[Long],
> val maxOffHeapMemory: Option[Long])
> {code}
> Here are 6 memory related fields: {{memoryUsed}}, {{maxMemory}},
> {{onHeapMemoryUsed}}, {{offHeapMemoryUsed}}, {{maxOnHeapMemory}},
> {{maxOffHeapMemory}}.
> These all 6 fields reflects the *storage* memory usage in Spark, but from the
> name of this 6 fields, user doesn't really know it is referring to *storage*
> memory or the total memory (storage memory + execution memory). This will be
> misleading.
> So I think we should properly rename these fields to reflect their real
> meanings. Or we should will document it.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
