[
https://issues.apache.org/jira/browse/SPARK-4066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14183235#comment-14183235
]
Patrick Wendell commented on SPARK-4066:
----------------------------------------
[~srowen] I don't see a good argument for coercing this for all developers and
not allowing it to be disabled. We already check for scalastyle on patch
submissions, so we don't waste any review cycles dealing with style issues (if
someone's patch needs style fixes, I just tell them to go fix it). For
individual developers, if they want to run style checks, they can do it easily
using dev/scalastyle. So I don't see much marginal benefit to forcing it on
compile. At the same time there is a clear cost which is that is cumbersome for
some developers - hence the e-mail to the list. Some developers might prefer to
punt style issues to the end of their dev cycle (personally I don't, but why
should Spark enforce this?). There are also cases such as if a user is working
on XML code that requires style exceptions in order to compile correctly, it's
much easier to develop it first and then go and add exceptions later. Another
case is if a user is borrowing code from some other codebase that they plan to
modify, which had different style rules. Why should we force them to clean up
the style for a compile to succeed?
So basically, I see only minor benefits to coercing these checks and some very
evident costs. So that's why I'm in favor of removing them by default or, at a
minimum, allowing them to be disabled.
> Make whether maven builds fails on scalastyle violation configurable
> --------------------------------------------------------------------
>
> Key: SPARK-4066
> URL: https://issues.apache.org/jira/browse/SPARK-4066
> Project: Spark
> Issue Type: Improvement
> Reporter: Ted Yu
> Priority: Minor
> Attachments: spark-4066-v1.txt
>
>
> Here is the thread Koert started:
> http://search-hadoop.com/m/JW1q5j8z422/scalastyle+annoys+me+a+little+bit&subj=scalastyle+annoys+me+a+little+bit
> It would be flexible if whether maven build fails due to scalastyle violation
> configurable.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
