[ 
https://issues.apache.org/jira/browse/SPARK-20839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16019625#comment-16019625
 ] 

Sean Owen commented on SPARK-20839:
-----------------------------------

Why do you think so? A test case demonstrating the actual vs expected output, 
and why the expected output is correct, would help.
Please review existing issues about the PageRank implementation in JIRA, some 
of which were closed as not a bug.

> Incorrect Dynamic PageRank calculation
> --------------------------------------
>
>                 Key: SPARK-20839
>                 URL: https://issues.apache.org/jira/browse/SPARK-20839
>             Project: Spark
>          Issue Type: Bug
>          Components: GraphX
>    Affects Versions: 2.1.1
>            Reporter: BahaaEddin AlAila
>
> Correct me if I am wrong
> I think there are two places where the pagerank calculation is incorrect
> 1st) in the VertexProgram (line 318 of PageRank.scala in spark 2.1.1)
> val newPR = oldPR + (1.0 - resetProb) * msgSum
> it should be
> val newPR = resetProb + (1.0 - resetProb) * msgSum
> 2nd) in the message sending part (line 336 of the same file)
> Iterator((edge.dstId, edge.srcAttr._2 * edge.attr))
> should be 
> Iterator((edge.dstId, edge.srcAttr._1 * edge.attr))
> as we should be sending the edge weight multiplied by the current pagerank of 
> the source vertex (not the vertex's delta)



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org

Reply via email to