[
https://issues.apache.org/jira/browse/SPARK-20891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16025459#comment-16025459
]
Ruben Janssen commented on SPARK-20891:
---------------------------------------
I thought it would be cleaner to have separate JIRAs because this would be
needed despite the addition of new features.
For example, if someone wanted to add a new function while SPARK-20890 was
still pending, we would need another subsequent JIRA to fix the duplicate code,
as the new function would not be aligned with the code duplication measures
taken in 20890.
I don't mind closing this JIRA however and resolving the code duplication issue
in 20891 however, if you prefer.
> Reduce duplicate code in typedaggregators.scala
> -----------------------------------------------
>
> Key: SPARK-20891
> URL: https://issues.apache.org/jira/browse/SPARK-20891
> Project: Spark
> Issue Type: Sub-task
> Components: SQL
> Affects Versions: 2.3.0
> Reporter: Ruben Janssen
>
> With SPARK-20411, a significant amount of functions will be added to
> typedaggregators.scala, resulting in a large amount of duplicate code
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
