[ 
https://issues.apache.org/jira/browse/SPARK-20952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16043655#comment-16043655
 ] 

Shixiong Zhu commented on SPARK-20952:
--------------------------------------

If TaskContext is not inheritable, we can always find a way to pass it to the 
codes that need to access it. But if it's inheritable, it's pretty hard to 
avoid TaskContext pollution (or avoid using a stale TaskContext, you have to 
always set it manually in a task running in a cached thread).

[~joshrosen] listed many tickets that are caused by localProperties is 
InheritableThreadLocal: 
https://issues.apache.org/jira/browse/SPARK-14686?focusedCommentId=15244478&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15244478

> TaskContext should be an InheritableThreadLocal
> -----------------------------------------------
>
>                 Key: SPARK-20952
>                 URL: https://issues.apache.org/jira/browse/SPARK-20952
>             Project: Spark
>          Issue Type: Bug
>          Components: Spark Core
>    Affects Versions: 2.1.1
>            Reporter: Robert Kruszewski
>            Priority: Minor
>
> TaskContext is a ThreadLocal as a result when you fork a thread inside your 
> executor task you lose the handle on the original context set by the 
> executor. We should change it to InheritableThreadLocal so we can access it 
> inside thread pools on executors. 
> See ParquetFileFormat#readFootersInParallel for example of code that uses 
> thread pools inside the tasks.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org

Reply via email to