[ 
https://issues.apache.org/jira/browse/SPARK-21218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16065177#comment-16065177
 ] 

Andrew Duffy edited comment on SPARK-21218 at 6/27/17 5:39 PM:
---------------------------------------------------------------

Curious, I wonder what the previous benchmarks were lacking.

 Have you tried disjunction push-down on other datatypes, e.g. strings? In any 
case, I'm also on board with this change, if it is in fact useful.

I think [~hyukjin.kwon] was saying we should close this as a dupe, and rename 
the PR with the original ticket number 
[17091|https://issues.apache.org/jira/browse/SPARK-17091]. You can re-open that 
issue and say that you've done tests where this now looks like it will be a big 
improvement.


was (Author: andreweduffy):
Curious, I wonder what the previous benchmarks were lacking.

 Have you tried disjunction push-down on other datatypes, e.g. strings? In any 
case, I'm also on board with this change, if it is in fact useful.

I think [~hyukjin.kwon] was saying we should close this as a dupe, and rename 
the PR with the original ticket number (#17091). You can re-open that issue and 
say that you've done tests where this now looks like it will be a big 
improvement.

> Convert IN predicate to equivalent Parquet filter
> -------------------------------------------------
>
>                 Key: SPARK-21218
>                 URL: https://issues.apache.org/jira/browse/SPARK-21218
>             Project: Spark
>          Issue Type: Improvement
>          Components: Optimizer
>    Affects Versions: 2.1.1
>            Reporter: Michael Styles
>         Attachments: IN Predicate.png, OR Predicate.png
>
>
> Convert IN predicate to equivalent expression involving equality conditions 
> to allow the filter to be pushed down to Parquet.
> For instance,
> C1 IN (10, 20) is rewritten as (C1 = 10) OR (C1 = 20)



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org

Reply via email to