[ https://issues.apache.org/jira/browse/SPARK-21644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16121946#comment-16121946 ]
Xiao Li commented on SPARK-21644: --------------------------------- https://github.com/apache/spark/pull/18851 > LocalLimit.maxRows is defined incorrectly > ----------------------------------------- > > Key: SPARK-21644 > URL: https://issues.apache.org/jira/browse/SPARK-21644 > Project: Spark > Issue Type: Bug > Components: SQL > Affects Versions: 2.2.0 > Reporter: Reynold Xin > Assignee: Reynold Xin > > {code} > case class LocalLimit(limitExpr: Expression, child: LogicalPlan) extends > UnaryNode { > override def output: Seq[Attribute] = child.output > override def maxRows: Option[Long] = { > limitExpr match { > case IntegerLiteral(limit) => Some(limit) > case _ => None > } > } > } > {code} > This is simply wrong, since LocalLimit is only about partition level limits. -- This message was sent by Atlassian JIRA (v6.4.14#64029) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org For additional commands, e-mail: issues-h...@spark.apache.org