[ 
https://issues.apache.org/jira/browse/SPARK-21903?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Apache Spark reassigned SPARK-21903:
------------------------------------

    Assignee:     (was: Apache Spark)

> Upgrade scalastyle to 1.0.0
> ---------------------------
>
>                 Key: SPARK-21903
>                 URL: https://issues.apache.org/jira/browse/SPARK-21903
>             Project: Spark
>          Issue Type: Improvement
>          Components: Build
>    Affects Versions: 2.3.0
>            Reporter: Hyukjin Kwon
>            Priority: Trivial
>
> 1.0.0 fixes an issue with import order, explicit type for public methods, 
> line length limitation and comment validation:
> {code}
> [error] 
> .../spark/repl/scala-2.11/src/main/scala/org/apache/spark/repl/Main.scala:50:16:
>  Are you sure you want to println? If yes, wrap the code block with
> [error]       // scalastyle:off println
> [error]       println(...)
> [error]       // scalastyle:on println
> [error] 
> .../spark/repl/scala-2.11/src/main/scala/org/apache/spark/repl/SparkILoop.scala:49:
>  File line length exceeds 100 characters
> [error] 
> .../spark/repl/scala-2.11/src/main/scala/org/apache/spark/repl/SparkILoop.scala:22:21:
>  Are you sure you want to println? If yes, wrap the code block with
> [error]       // scalastyle:off println
> [error]       println(...)
> [error]       // scalastyle:on println
> [error] 
> .../spark/streaming/src/test/java/org/apache/spark/streaming/JavaTestUtils.scala:35:6:
>  Public method must have explicit type
> [error] 
> .../spark/streaming/src/test/java/org/apache/spark/streaming/JavaTestUtils.scala:51:6:
>  Public method must have explicit type
> [error] 
> .../spark/streaming/src/test/java/org/apache/spark/streaming/JavaTestUtils.scala:93:15:
>  Public method must have explicit type
> [error] 
> .../spark/streaming/src/test/java/org/apache/spark/streaming/JavaTestUtils.scala:98:15:
>  Public method must have explicit type
> [error] 
> .../spark/streaming/src/test/java/org/apache/spark/streaming/JavaTestUtils.scala:47:2:
>  Insert a space after the start of the comment
> [error] 
> .../spark/streaming/src/test/java/org/apache/spark/streaming/JavaTestUtils.scala:26:43:
>  JavaDStream should come before JavaDStreamLike.
> {code}
> I am also interested in {{org.scalastyle.scalariform.OverrideJavaChecker}} 
> feature, which we had to work around to check this SPARK-16877, which was 
> added from 0.9.0.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org

Reply via email to