[ 
https://issues.apache.org/jira/browse/SPARK-21997?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dongjoon Hyun updated SPARK-21997:
----------------------------------
    Description: 
SPARK-19459 resolves CHAR/VARCHAR issues in general, but Spark shows different 
results according to the SQL configuration, 
*spark.sql.hive.convertMetastoreParquet*. We had better fix this. Actually, the 
default of `spark.sql.hive.convertMetastoreParquet` is true, so the result is 
wrong by default.

{code}
scala> sql("CREATE TABLE t_char(a CHAR(10), b VARCHAR(10)) STORED AS parquet")
scala> sql("INSERT INTO TABLE t_char SELECT 'a', 'b'")
scala> sql("SELECT * FROM t_char").show
+---+---+
|  a|  b|
+---+---+
|  a|  b|
+---+---+

scala> sql("set spark.sql.hive.convertMetastoreParquet=false")

scala> sql("SELECT * FROM t_char").show
+----------+---+
|         a|  b|
+----------+---+
|a         |  b|
+----------+---+
{code}

  was:
SPARK-19459 resolves CHAR/VARCHAR issues in general, but Spark shows different 
results according to the SQL configuration, 
*spark.sql.hive.convertMetastoreParquet*. We had better fix this. Actually, the 
default of `spark.sql.hive.convertMetastoreParquet` is true, so the result is 
wrong by default.

For ORC, the default of `spark.sql.hive.convertMetastoreOrc` is false, so 
SPARK-19459 didn't resolve this together. For ORC, it will happen if we turn on 
it `true`.

{code}
scala> sql("CREATE TABLE t_char(a CHAR(10), b VARCHAR(10)) STORED AS parquet")
scala> sql("INSERT INTO TABLE t_char SELECT 'a', 'b'")
scala> sql("SELECT * FROM t_char").show
+---+---+
|  a|  b|
+---+---+
|  a|  b|
+---+---+

scala> sql("set spark.sql.hive.convertMetastoreParquet=false")

scala> sql("SELECT * FROM t_char").show
+----------+---+
|         a|  b|
+----------+---+
|a         |  b|
+----------+---+
{code}


> Spark shows different results on char/varchar columns on Parquet
> ----------------------------------------------------------------
>
>                 Key: SPARK-21997
>                 URL: https://issues.apache.org/jira/browse/SPARK-21997
>             Project: Spark
>          Issue Type: Bug
>          Components: SQL
>    Affects Versions: 2.0.2, 2.1.1, 2.2.0
>            Reporter: Dongjoon Hyun
>
> SPARK-19459 resolves CHAR/VARCHAR issues in general, but Spark shows 
> different results according to the SQL configuration, 
> *spark.sql.hive.convertMetastoreParquet*. We had better fix this. Actually, 
> the default of `spark.sql.hive.convertMetastoreParquet` is true, so the 
> result is wrong by default.
> {code}
> scala> sql("CREATE TABLE t_char(a CHAR(10), b VARCHAR(10)) STORED AS parquet")
> scala> sql("INSERT INTO TABLE t_char SELECT 'a', 'b'")
> scala> sql("SELECT * FROM t_char").show
> +---+---+
> |  a|  b|
> +---+---+
> |  a|  b|
> +---+---+
> scala> sql("set spark.sql.hive.convertMetastoreParquet=false")
> scala> sql("SELECT * FROM t_char").show
> +----------+---+
> |         a|  b|
> +----------+---+
> |a         |  b|
> +----------+---+
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org

Reply via email to