[
https://issues.apache.org/jira/browse/SPARK-22269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16203873#comment-16203873
]
Marcelo Vanzin commented on SPARK-22269:
----------------------------------------
I'm saying that we should at least investigate whether there's a way to run
checkstyle through sbt, since that's the default for the PR builder, like we do
for scalastyle.
Otherwise what's the point of having these checks? Other than to constantly
have to fix style issues introduced by other changes?
> Java style checks should be run in Jenkins
> ------------------------------------------
>
> Key: SPARK-22269
> URL: https://issues.apache.org/jira/browse/SPARK-22269
> Project: Spark
> Issue Type: Improvement
> Components: Build
> Affects Versions: 2.3.0
> Reporter: Andrew Ash
> Priority: Minor
>
> A few times now I've gone to build the master branch and it's failed due to
> Java style errors, which I've sent in PRs to fix:
> - https://issues.apache.org/jira/browse/SPARK-22268
> - https://issues.apache.org/jira/browse/SPARK-21875
> Digging through the history a bit, it looks like this check used to run on
> Jenkins and was previously enabled at
> https://github.com/apache/spark/pull/10763 but then reverted at
> https://github.com/apache/spark/commit/4bcea1b8595424678aa6c92d66ba08c92e0fefe5
> We should work out what it takes to enable the Java check in Jenkins so these
> kinds of errors are caught in CI rather than afterwards post-merge.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
