[ 
https://issues.apache.org/jira/browse/SPARK-22308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16211207#comment-16211207
 ] 

Nathan Kronenfeld commented on SPARK-22308:
-------------------------------------------

I can't disagree more strongly.

What you get then is people just copy-pasting this code into their own code 
base.

This is what we've been doing for years. We tried a number of iterations of our 
own test harness that kept failing for one reason or another, until we finally 
copied what Spark core was doing, and it all worked.

I was excited to learn that the test jars were finally being published, so we 
could stop keeping our own copy of SharedSparkContext.  But now we either can't 
use SharedSQLContext, or have to make our tests conform to Spark's patterns

To say to the Spark community, 'sure you can use our stuff, but you're on your 
own for testing" is.... well, not helpful in the least.  Testing is an integral 
part of using any product.

> Support unit tests of spark code using ScalaTest using suites other than 
> FunSuite
> ---------------------------------------------------------------------------------
>
>                 Key: SPARK-22308
>                 URL: https://issues.apache.org/jira/browse/SPARK-22308
>             Project: Spark
>          Issue Type: Improvement
>          Components: Documentation, Spark Core, SQL, Tests
>    Affects Versions: 2.2.0
>            Reporter: Nathan Kronenfeld
>            Priority: Minor
>              Labels: scalatest, test-suite, test_issue
>
> External codebases that have spark code can test it using SharedSparkContext, 
> no matter how they write their scalatests - basing on FunSuite, FunSpec, 
> FlatSpec, or WordSpec.
> SharedSQLContext only supports FunSuite.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org

Reply via email to