[ 
https://issues.apache.org/jira/browse/SPARK-22400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Zhenhua Wang updated SPARK-22400:
---------------------------------
    Description: 
Both `ReadSupport` and `ReadTask` have a method called `createReader`, but they 
create different things. This could cause some confusion for data source 
developers. The same issue exists between `WriteSupport` and 
`DataWriterFactory`, both of which have a method called `createWriter`.

Besides, the name of `RowToInternalRowDataWriterFactory` is not correct, 
because it actually converts `InternalRow`s to `Row`s.

  was:
Both `ReadSupport` and `ReadTask` have a method called `createReader`, but they 
create different things. This could cause some confusion for data source 
developers. The same problem exists between `WriteSupport` and 
`DataWriterFactory`, both of which have a method called `createWriter`.

Besides, the name of `RowToInternalRowDataWriterFactory` is not correct, 
because it actually converts `InternalRow`s to `Row`s.


> rename some APIs and classes to make their meaning clearer
> ----------------------------------------------------------
>
>                 Key: SPARK-22400
>                 URL: https://issues.apache.org/jira/browse/SPARK-22400
>             Project: Spark
>          Issue Type: Sub-task
>          Components: SQL
>    Affects Versions: 2.3.0
>            Reporter: Zhenhua Wang
>
> Both `ReadSupport` and `ReadTask` have a method called `createReader`, but 
> they create different things. This could cause some confusion for data source 
> developers. The same issue exists between `WriteSupport` and 
> `DataWriterFactory`, both of which have a method called `createWriter`.
> Besides, the name of `RowToInternalRowDataWriterFactory` is not correct, 
> because it actually converts `InternalRow`s to `Row`s.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to