[ 
https://issues.apache.org/jira/browse/SPARK-13030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16227094#comment-16227094
 ] 

yuhao yang commented on SPARK-13030:
------------------------------------

I see. Thanks for the response [~mlnick].

The Estimator is necessary if we want to automatically infer the size.

Then for adding the extra param size or not, I guess it will be useful in the 
case that automatic inference should not be used (E.g. Sampling before 
training). I would vote for adding.



> Change OneHotEncoder to Estimator
> ---------------------------------
>
>                 Key: SPARK-13030
>                 URL: https://issues.apache.org/jira/browse/SPARK-13030
>             Project: Spark
>          Issue Type: Improvement
>          Components: ML
>    Affects Versions: 1.6.0
>            Reporter: Wojciech Jurczyk
>
> OneHotEncoder should be an Estimator, just like in scikit-learn 
> (http://scikit-learn.org/stable/modules/generated/sklearn.preprocessing.OneHotEncoder.html).
> In its current form, it is impossible to use when number of categories is 
> different between training dataset and test dataset.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org

Reply via email to