[ 
https://issues.apache.org/jira/browse/SPARK-22441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16238844#comment-16238844
 ] 

Sean Owen commented on SPARK-22441:
-----------------------------------

That's great info. The current mapping is, I think, more natural, despite what 
this doc says. If there's ambiguity, I think keeping current behavior is best.

However what about this? 

{code}
      case DoubleType => Option(JdbcType("DOUBLE PRECISION", 
java.sql.Types.DOUBLE))
      case FloatType => Option(JdbcType("REAL", java.sql.Types.FLOAT))
{code}

The reverse mapping maps FloatType to REAL, not FLOAT. Is that a problem?

> JDBC REAL type is mapped to Double instead of Float
> ---------------------------------------------------
>
>                 Key: SPARK-22441
>                 URL: https://issues.apache.org/jira/browse/SPARK-22441
>             Project: Spark
>          Issue Type: Bug
>          Components: SQL
>    Affects Versions: 2.2.0
>            Reporter: Hongbo
>            Priority: Minor
>
> In [JDBC 
> Specification|http://download.oracle.com/otn-pub/jcp/jdbc-4_1-mrel-eval-spec/jdbc4.1-fr-spec.pdf],
>  REAL should be mapped to Float. 
> But now, it's mapped to Double:
> [https://github.com/apache/spark/blob/bc7ca9786e162e33f29d57c4aacb830761b97221/sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala#L220]
> Should it be changed according to the specification?



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org

Reply via email to