[
https://issues.apache.org/jira/browse/SPARK-22360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16289803#comment-16289803
]
Sandor Murakozi edited comment on SPARK-22360 at 12/13/17 8:09 PM:
-------------------------------------------------------------------
I just did a quick check of the existing test cases to see the current coverage:
different partition clauses
* None
** Window.rowsBetween
** reverse unbounded range frame
** window function with aggregates
** Null inputs
* One
** Lots of tests
* Multiple
** No test
different order clauses
* None
** Window.rowsBetween
** window function should fail if order by clause is not specified
** statistical functions
* One
** Lots of tests
* Multiple
** No test
* asc
** lots of tests
* desc
** aggregation and range between with unbounded
** reverse sliding range frame
** reverse unbounded range frame
* nulls first/last
** last/first with ignoreNulls
I will create tests for those that are not yet covered. I will also check if
there are any special combinations (possibly also considering frames) that
require additional test cases.
[~jiangxb] are there other cases that need to be covered?
Do you think it would be worthwhile to have a set of new test cases focusing
and systematically going through all the partition and order clauses?
was (Author: smurakozi):
I just did a quick check of the existing test cases to see the current coverage:
different partition clauses
* None
** Window.rowsBetween
** reverse unbounded range frame
** window function with aggregates
** Null inputs
* One
** Lots of tests
* Multiple
** No test
different order clauses
* None
** Window.rowsBetween
** window function should fail if order by clause is not specified
** statistical functions
* One
** Lots of tests
* Multiple
** No test
* asc
** lots of tests
* desc
** aggregation and range between with unbounded
** reverse sliding range frame
** reverse unbounded range frame
* nulls first/last
** last/first with ignoreNulls
I will create tests for those that are not yet covered. I will also check if
there are any special combinations (possibly also considering frames) that
require additional test cases.
[~jiangxb] are there other cases that need to be covered?
Do you think it would be worthwhile to have a set of new test cases focusing
and systematically going through all the partition and order clauses?
> Add unit test for Window Specifications
> ---------------------------------------
>
> Key: SPARK-22360
> URL: https://issues.apache.org/jira/browse/SPARK-22360
> Project: Spark
> Issue Type: Sub-task
> Components: SQL
> Affects Versions: 2.3.0
> Reporter: Jiang Xingbo
>
> * different partition clauses (none, one, multiple)
> * different order clauses (none, one, multiple, asc/desc, nulls first/last)
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
