[ https://issues.apache.org/jira/browse/SPARK-23349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16355137#comment-16355137 ]
Apache Spark commented on SPARK-23349: -------------------------------------- User 'wujianping10043419' has created a pull request for this issue: https://github.com/apache/spark/pull/20526 > Duplicate and redundant type determination for ShuffleManager Object > -------------------------------------------------------------------- > > Key: SPARK-23349 > URL: https://issues.apache.org/jira/browse/SPARK-23349 > Project: Spark > Issue Type: Improvement > Components: Shuffle, SQL > Affects Versions: 2.2.1 > Reporter: Phoenix_Daddy > Priority: Minor > Fix For: 2.2.1 > > > org.apache.spark.sql.execution.exchange.ShuffleExchange > In the "needtocopyobjectsbeforguffle()" function,there is a nested "if or > else" branch . > The <sortBasedShufffleOn> condition in the first layer "if" has the same > value as the <bypassIsSupported> condition in the second layer "if", that is, > <bypassIsSupported> must be true when <sortBasedShufffleOn> is true. > In addition, the <byPassMergeThreshold> condition will be used in the second > layer "if" and should not be calculated until needed. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org For additional commands, e-mail: issues-h...@spark.apache.org