[ https://issues.apache.org/jira/browse/SPARK-23383?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kent Yao updated SPARK-23383: ----------------------------- Description: {code:java} ./dev/make-distribution.sh --name ne-1.0.0-SNAPSHOT xyz --tgz -Phadoop-2.7 +++ dirname ./dev/make-distribution.sh ++ cd ./dev/.. ++ pwd + SPARK_HOME=/Users/Kent/Documents/spark + DISTDIR=/Users/Kent/Documents/spark/dist + MAKE_TGZ=false + MAKE_PIP=false + MAKE_R=false + NAME=none + MVN=/Users/Kent/Documents/spark/build/mvn + (( 5 )) + case $1 in + NAME=ne-1.0.0-SNAPSHOT + shift + shift + (( 3 )) + case $1 in + break + '[' -z /Users/Kent/.jenv/candidates/java/current ']' + '[' -z /Users/Kent/.jenv/candidates/java/current ']' ++ command -v git + '[' /usr/local/bin/git ']' ++ git rev-parse --short HEAD + GITREV=98ea6a7 + '[' '!' -z 98ea6a7 ']' + GITREVSTRING=' (git revision 98ea6a7)' + unset GITREV ++ command -v /Users/Kent/Documents/spark/build/mvn + '[' '!' /Users/Kent/Documents/spark/build/mvn ']' ++ /Users/Kent/Documents/spark/build/mvn help:evaluate -Dexpression=project.version xyz --tgz -Phadoop-2.7 ++ grep -v INFO ++ tail -n 1 + VERSION=' -X,--debug Produce execution debug output' {code} It is better to declare the mistakes and exit with usage was: ``` ./dev/make-distribution.sh --name ne-1.0.0-SNAPSHOT xyz --tgz -Phadoop-2.7 +++ dirname ./dev/make-distribution.sh ++ cd ./dev/.. ++ pwd + SPARK_HOME=/Users/Kent/Documents/spark + DISTDIR=/Users/Kent/Documents/spark/dist + MAKE_TGZ=false + MAKE_PIP=false + MAKE_R=false + NAME=none + MVN=/Users/Kent/Documents/spark/build/mvn + (( 5 )) + case $1 in + NAME=ne-1.0.0-SNAPSHOT + shift + shift + (( 3 )) + case $1 in + break + '[' -z /Users/Kent/.jenv/candidates/java/current ']' + '[' -z /Users/Kent/.jenv/candidates/java/current ']' ++ command -v git + '[' /usr/local/bin/git ']' ++ git rev-parse --short HEAD + GITREV=98ea6a7 + '[' '!' -z 98ea6a7 ']' + GITREVSTRING=' (git revision 98ea6a7)' + unset GITREV ++ command -v /Users/Kent/Documents/spark/build/mvn + '[' '!' /Users/Kent/Documents/spark/build/mvn ']' ++ /Users/Kent/Documents/spark/build/mvn help:evaluate -Dexpression=project.version xyz --tgz -Phadoop-2.7 ++ grep -v INFO ++ tail -n 1 + VERSION=' -X,--debug Produce execution debug output' ``` It is better to declare the mistakes and exit with usage > Make a distribution should exit with usage while detecting wrong options > ------------------------------------------------------------------------ > > Key: SPARK-23383 > URL: https://issues.apache.org/jira/browse/SPARK-23383 > Project: Spark > Issue Type: Bug > Components: Build > Affects Versions: 2.2.1 > Reporter: Kent Yao > Priority: Minor > > {code:java} > ./dev/make-distribution.sh --name ne-1.0.0-SNAPSHOT xyz --tgz -Phadoop-2.7 > +++ dirname ./dev/make-distribution.sh > ++ cd ./dev/.. > ++ pwd > + SPARK_HOME=/Users/Kent/Documents/spark > + DISTDIR=/Users/Kent/Documents/spark/dist > + MAKE_TGZ=false > + MAKE_PIP=false > + MAKE_R=false > + NAME=none > + MVN=/Users/Kent/Documents/spark/build/mvn > + (( 5 )) > + case $1 in > + NAME=ne-1.0.0-SNAPSHOT > + shift > + shift > + (( 3 )) > + case $1 in > + break > + '[' -z /Users/Kent/.jenv/candidates/java/current ']' > + '[' -z /Users/Kent/.jenv/candidates/java/current ']' > ++ command -v git > + '[' /usr/local/bin/git ']' > ++ git rev-parse --short HEAD > + GITREV=98ea6a7 > + '[' '!' -z 98ea6a7 ']' > + GITREVSTRING=' (git revision 98ea6a7)' > + unset GITREV > ++ command -v /Users/Kent/Documents/spark/build/mvn > + '[' '!' /Users/Kent/Documents/spark/build/mvn ']' > ++ /Users/Kent/Documents/spark/build/mvn help:evaluate > -Dexpression=project.version xyz --tgz -Phadoop-2.7 > ++ grep -v INFO > ++ tail -n 1 > + VERSION=' -X,--debug Produce execution debug > output' > {code} > It is better to declare the mistakes and exit with usage -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org For additional commands, e-mail: issues-h...@spark.apache.org