Kris Mok created SPARK-23960:
--------------------------------

             Summary: Mark HashAggregateExec.bufVars as transient
                 Key: SPARK-23960
                 URL: https://issues.apache.org/jira/browse/SPARK-23960
             Project: Spark
          Issue Type: Improvement
          Components: SQL
    Affects Versions: 2.3.0
            Reporter: Kris Mok


{{HashAggregateExec.bufVars}} is only used during codegen for global 
aggregation. Specifically it's only used while {{doProduceWithoutKeys()}} is on 
the stack.
Currently, if an {{HashAggregateExec}} is ever captured for serialization, the 
{{bufVars}} would be needlessly serialized.

This ticket proposes a minor change to mark the {{bufVars}} field as transient 
to avoid serializing it. Also, null out this field at the end of 
{{doProduceWithoutKeys()}} to reduce its lifecycle so that the 
{{Seq[ExprCode]}} being referenced can be GC'd sooner.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org

Reply via email to