[ 
https://issues.apache.org/jira/browse/SPARK-24325?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Maxim Gekk updated SPARK-24325:
-------------------------------
    Description: 
Currently, there are no tests for [Hadoop 
LinesReader|https://github.com/apache/spark/blob/8d79113b812a91073d2c24a3a9ad94cc3b90b24a/sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/HadoopFileLinesReader.scala#L42].
 For refactoring or rewriting of the class, need to add tests that cover basic 
functionality of the class like:
 * Split's boundaries slice lines
 * A split slices delimiters - user's specified or defaults
 * No duplicates if splits slice delimiters or lines
 * Checking constant limits like maximum line length
 * Handling a case when internal buffers size is less than line size

  was:
Currently, there are no tests for [Hadoop 
LineReader|https://github.com/apache/spark/blob/8d79113b812a91073d2c24a3a9ad94cc3b90b24a/sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/HadoopFileLinesReader.scala#L42].
 For refactoring or rewriting of the class, need to add tests that cover basic 
functionality of the class like:

* Split's boundaries slice lines
* A split slices delimiters - user's specified or defaults
* No duplicates if splits slice delimiters or lines
* Checking constant limits like maximum line length
* Handling a case when internal buffers size is less than line size 


> Tests for Hadoop's LinesReader
> ------------------------------
>
>                 Key: SPARK-24325
>                 URL: https://issues.apache.org/jira/browse/SPARK-24325
>             Project: Spark
>          Issue Type: Sub-task
>          Components: SQL
>    Affects Versions: 2.3.0
>            Reporter: Maxim Gekk
>            Priority: Minor
>
> Currently, there are no tests for [Hadoop 
> LinesReader|https://github.com/apache/spark/blob/8d79113b812a91073d2c24a3a9ad94cc3b90b24a/sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/HadoopFileLinesReader.scala#L42].
>  For refactoring or rewriting of the class, need to add tests that cover 
> basic functionality of the class like:
>  * Split's boundaries slice lines
>  * A split slices delimiters - user's specified or defaults
>  * No duplicates if splits slice delimiters or lines
>  * Checking constant limits like maximum line length
>  * Handling a case when internal buffers size is less than line size



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org

Reply via email to