[
https://issues.apache.org/jira/browse/SPARK-24330?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gengliang Wang updated SPARK-24330:
-----------------------------------
Description:
Refactor ExecuteWriteTask in FileFormatWriter to reduce common logic and
improve readability.
After the change, callers only need to call {{commit()}} or {{abort}} at the
end of task.
Also there is less code in {{SingleDirectoryWriteTask}} and
{{DynamicPartitionWriteTask}}.
Definitions of related classes are moved to a new file, and
{{ExecuteWriteTask}} is renamed to {{FileFormatDataWriter}}.
was:
As I am working on File data source V2 write path in my repo
[https://github.com/gengliangwang/spark/tree/orcWriter] , I find it essential
to refactor ExecuteWriteTask in FileFormatWriter with DataWriter of Data source
V2:
# Reuse the code in both `FileFormat` and Data Source V2
# Better abstraction, callers only need to call `commit()` or `abort` at the
end of task.
> Refactor ExecuteWriteTask in FileFormatWriter with DataWriter(V2)
> -----------------------------------------------------------------
>
> Key: SPARK-24330
> URL: https://issues.apache.org/jira/browse/SPARK-24330
> Project: Spark
> Issue Type: Improvement
> Components: SQL
> Affects Versions: 2.3.1
> Reporter: Gengliang Wang
> Priority: Major
>
> Refactor ExecuteWriteTask in FileFormatWriter to reduce common logic and
> improve readability.
> After the change, callers only need to call {{commit()}} or {{abort}} at the
> end of task.
> Also there is less code in {{SingleDirectoryWriteTask}} and
> {{DynamicPartitionWriteTask}}.
> Definitions of related classes are moved to a new file, and
> {{ExecuteWriteTask}} is renamed to {{FileFormatDataWriter}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
