[ https://issues.apache.org/jira/browse/SPARK-24515?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
zhoukang updated SPARK-24515: ----------------------------- Description: {code:java} {code} No need to warning user when output commit coordination enabled {code} // When speculation is on and output committer class name contains "Direct", we should warn // users that they may loss data if they are using a direct output committer. val speculationEnabled = self.conf.getBoolean("spark.speculation", false) val outputCommitterClass = hadoopConf.get("mapred.output.committer.class", "") if (speculationEnabled && outputCommitterClass.contains("Direct")) { val warningMessage = s"$outputCommitterClass may be an output committer that writes data directly to " + "the final location. Because speculation is enabled, this output committer may " + "cause data loss (see the case in SPARK-10063). If possible, please use an output " + "committer that does not have this behavior (e.g. FileOutputCommitter)." logWarning(warningMessage) } {code} {code:java} // code placeholder {code} was: {code:java} // When speculation is on and output committer class name contains "Direct", we should warn // users that they may loss data if they are using a direct output committer. val speculationEnabled = self.conf.getBoolean("spark.speculation", false) val outputCommitterClass = hadoopConf.get("mapred.output.committer.class", "") if (speculationEnabled && outputCommitterClass.contains("Direct")) { val warningMessage = s"$outputCommitterClass may be an output committer that writes data directly to " + "the final location. Because speculation is enabled, this output committer may " + "cause data loss (see the case in SPARK-10063). If possible, please use an output " + "committer that does not have this behavior (e.g. FileOutputCommitter)." logWarning(warningMessage) } {code} No need to warning user when output commit coordination enabled > No need to warning user when output commit coordination enabled > --------------------------------------------------------------- > > Key: SPARK-24515 > URL: https://issues.apache.org/jira/browse/SPARK-24515 > Project: Spark > Issue Type: Improvement > Components: Spark Core > Affects Versions: 2.3.1 > Reporter: zhoukang > Priority: Major > > > {code:java} > {code} > No need to warning user when output commit coordination enabled > {code} > // When speculation is on and output committer class name contains "Direct", > we should warn > // users that they may loss data if they are using a direct output committer. > val speculationEnabled = self.conf.getBoolean("spark.speculation", false) > val outputCommitterClass = hadoopConf.get("mapred.output.committer.class", "") > if (speculationEnabled && outputCommitterClass.contains("Direct")) { > val warningMessage = > s"$outputCommitterClass may be an output committer that writes data directly > to " + > "the final location. Because speculation is enabled, this output committer > may " + > "cause data loss (see the case in SPARK-10063). If possible, please use an > output " + > "committer that does not have this behavior (e.g. FileOutputCommitter)." > logWarning(warningMessage) > } > {code} > {code:java} > // code placeholder > {code} -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org For additional commands, e-mail: issues-h...@spark.apache.org