[ https://issues.apache.org/jira/browse/SPARK-24714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16529373#comment-16529373 ]
Takeshi Yamamuro commented on SPARK-24714: ------------------------------------------ You needn't do that; feel free to make a pr for this ticket. btw, since this is trivial, I think you don't file a jira > AnalysisSuite should use ClassTag to check the runtime instance > --------------------------------------------------------------- > > Key: SPARK-24714 > URL: https://issues.apache.org/jira/browse/SPARK-24714 > Project: Spark > Issue Type: Test > Components: SQL > Affects Versions: 2.3.1 > Reporter: Chia-Ping Tsai > Priority: Minor > > {code:java} > test("SPARK-22614 RepartitionByExpression partitioning") { > def checkPartitioning[T <: Partitioning](numPartitions: Int, exprs: > Expression*): Unit = { > val partitioning = RepartitionByExpression(exprs, testRelation2, > numPartitions).partitioning > assert(partitioning.isInstanceOf[T]) // it always be true because of type > erasure > }{code} > Spark support the scala 2.10 and 2.11 so it is ok to introduce ClassTag to > correct the type check. > -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org For additional commands, e-mail: issues-h...@spark.apache.org