[ https://issues.apache.org/jira/browse/SPARK-25321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16610379#comment-16610379 ]
Weichen Xu commented on SPARK-25321: ------------------------------------ [~josephkb] There're 2 changes which break compatibility we need review: [SPARK-10413] ML models should support prediction on single instances: This PR break source and binary compatibility, if there're subclasses defined by users which override "protected predict" method. If we make `predict` public, then all subclasses must public there "predict" methods. What do you think of it? Is it a big issue ? [SPARK-14681] Provide label/impurity stats for spark.ml decision tree nodes: This will break binary compatibility, but it looks like keeping source compatibility. > ML, Graph 2.4 QA: API: New Scala APIs, docs > ------------------------------------------- > > Key: SPARK-25321 > URL: https://issues.apache.org/jira/browse/SPARK-25321 > Project: Spark > Issue Type: Sub-task > Components: Documentation, GraphX, ML, MLlib > Affects Versions: 2.4.0 > Reporter: Weichen Xu > Assignee: Yanbo Liang > Priority: Blocker > > Audit new public Scala APIs added to MLlib & GraphX. Take note of: > * Protected/public classes or methods. If access can be more private, then > it should be. > * Also look for non-sealed traits. > * Documentation: Missing? Bad links or formatting? > *Make sure to check the object doc!* > As you find issues, please create JIRAs and link them to this issue. > For *user guide issues* link the new JIRAs to the relevant user guide QA issue -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org For additional commands, e-mail: issues-h...@spark.apache.org