[ 
https://issues.apache.org/jira/browse/SPARK-24421?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16680439#comment-16680439
 ] 

Sean Owen commented on SPARK-24421:
-----------------------------------

Hey [~Bateman], thank you, yeah your comments and my edits just crossed. 

Yes, sun.misc.Unsafe is OK. It's sun.misc.Cleaner. Previous mistakes in the 
older post are my own, not Kris's.

See my last comment just above for what I think the situation is now.

I think we may have to accept that we can't hack the DirectByteBuffer 
allocation anymore all the time, and things still work, it's just that the user 
will have to set MaxDirectMemorySize or allow the reflective access if memory 
is an issue.

I'm still testing out whether this works out in practice.

> sun.misc.Unsafe in JDK11
> ------------------------
>
>                 Key: SPARK-24421
>                 URL: https://issues.apache.org/jira/browse/SPARK-24421
>             Project: Spark
>          Issue Type: Sub-task
>          Components: Build
>    Affects Versions: 2.3.0
>            Reporter: DB Tsai
>            Priority: Major
>
> Many internal APIs such as unsafe are encapsulated in JDK9+, see 
> http://openjdk.java.net/jeps/260 for detail.
> To use Unsafe, we need to add *jdk.unsupported* to our code’s module 
> declaration:
> {code:java}
> module java9unsafe {
>     requires jdk.unsupported;
> }
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org

Reply via email to