[ 
https://issues.apache.org/jira/browse/SPARK-26328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16715325#comment-16715325
 ] 

ASF GitHub Bot commented on SPARK-26328:
----------------------------------------

icexelloss opened a new pull request #23279: [SPARK-26328][SQL] Use 
GenerateOrdering for group key comparision in WindowExec
URL: https://github.com/apache/spark/pull/23279
 
 
   ## What changes were proposed in this pull request?
   
   Per discussion here: 
https://github.com/apache/spark/pull/22305/commits/850541873df1101485a85632b85ba474dac67d56#r239312302
   
   It seems better and more standard to use GenerateOrdering for group key 
comparison.
   
   
   ## How was this patch tested?
   
   Existing tests.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Use GenerateOrdering for group key comparison in WindowExec
> -----------------------------------------------------------
>
>                 Key: SPARK-26328
>                 URL: https://issues.apache.org/jira/browse/SPARK-26328
>             Project: Spark
>          Issue Type: Improvement
>          Components: SQL
>    Affects Versions: 2.4.0
>            Reporter: Li Jin
>            Priority: Major
>
> Per discussion here:
> [https://github.com/apache/spark/pull/22305/commits/850541873df1101485a85632b85ba474dac67d56#r239312302]
> It seems better to use GenerateOrdering for group key comparison in 
> WindowExec.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org

Reply via email to