[
https://issues.apache.org/jira/browse/SPARK-26327?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16716261#comment-16716261
]
ASF GitHub Bot commented on SPARK-26327:
----------------------------------------
HyukjinKwon commented on a change in pull request #23277: [SPARK-26327][SQL]
Metrics in FileSourceScanExec not update correctly
URL: https://github.com/apache/spark/pull/23277#discussion_r240480046
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/DataSourceScanExec.scala
##########
@@ -316,7 +313,7 @@ case class FileSourceScanExec(
override lazy val metrics =
Map("numOutputRows" -> SQLMetrics.createMetric(sparkContext, "number of
output rows"),
"numFiles" -> SQLMetrics.createMetric(sparkContext, "number of files"),
- "metadataTime" -> SQLMetrics.createMetric(sparkContext, "metadata time
(ms)"),
+ "fileListingTime" -> SQLMetrics.createMetric(sparkContext, "file listing
time (ms)"),
Review comment:
Yea, please fix PR description and title accordingly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Metrics in FileSourceScanExec not update correctly
> --------------------------------------------------
>
> Key: SPARK-26327
> URL: https://issues.apache.org/jira/browse/SPARK-26327
> Project: Spark
> Issue Type: Sub-task
> Components: SQL
> Affects Versions: 2.4.0
> Reporter: Yuanjian Li
> Priority: Major
>
> As currently approach in `FileSourceScanExec`, the metrics of "numFiles" and
> "metadataTime"(fileListingTime) were updated while lazy val
> `selectedPartitions` initialized. But `selectedPartitions` will be
> initialized by `metadata` at first, which is called by
> `queryExecution.toString` in `SQLExecution.withNewExecutionId`. So while the
> `SQLMetrics.postDriverMetricUpdates` called, there's no corresponding
> liveExecutions in SQLAppStatusListener, the metrics update is not work.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
