[
https://issues.apache.org/jira/browse/SPARK-25272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16717709#comment-16717709
]
ASF GitHub Bot commented on SPARK-25272:
----------------------------------------
BryanCutler closed pull request #22273: [SPARK-25272][PYTHON][TEST] Add test to
better indicate pyarrow is installed and related tests will run
URL: https://github.com/apache/spark/pull/22273
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/python/pyspark/sql/tests/test_arrow.py
b/python/pyspark/sql/tests/test_arrow.py
index 6e75e82d58009..ee054a9b9ac1f 100644
--- a/python/pyspark/sql/tests/test_arrow.py
+++ b/python/pyspark/sql/tests/test_arrow.py
@@ -30,6 +30,21 @@
from pyspark.util import _exception_message
+class HaveArrowTests(unittest.TestCase):
+
+ @unittest.skipIf(have_pandas and have_pyarrow,
+ "Required PyArrow and Pandas were found, Arrow tests will
run")
+ def test_required_pyarrow_pandas_not_installed(self):
+ # This is only to provide a output when skipped to show that the Arrow
tests will run
+ pass
+
+ @unittest.skipIf(not have_pandas or not have_pyarrow,
+ "Required PyArrow and Pandas not found, Arrow tests will
not run")
+ def test_required_pyarrow_pandas_installed(self):
+ # This is only to provide a output when skipped to show that the Arrow
tests will not run
+ pass
+
+
@unittest.skipIf(
not have_pandas or not have_pyarrow,
pandas_requirement_message or pyarrow_requirement_message)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Show some kind of test output to indicate pyarrow tests were run
> ----------------------------------------------------------------
>
> Key: SPARK-25272
> URL: https://issues.apache.org/jira/browse/SPARK-25272
> Project: Spark
> Issue Type: Sub-task
> Components: PySpark, Tests
> Affects Versions: 2.4.0
> Reporter: Bryan Cutler
> Assignee: Bryan Cutler
> Priority: Major
>
> Right now tests only output status when they are skipped and there is no way
> to really see from the logs that pyarrow tests, like ArrowTests, have been
> run except by the absence of a skipped message. We can add a test that is
> skipped if pyarrow is installed, which will give an output in our Jenkins
> test.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
