[
https://issues.apache.org/jira/browse/SPARK-25277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16717762#comment-16717762
]
ASF GitHub Bot commented on SPARK-25277:
----------------------------------------
vanzin commented on a change in pull request #22279: [SPARK-25277][YARN] YARN
applicationMaster metrics should not register static metrics
URL: https://github.com/apache/spark/pull/22279#discussion_r240746967
##########
File path: core/src/main/scala/org/apache/spark/metrics/MetricsSystem.scala
##########
@@ -103,6 +103,14 @@ private[spark] class MetricsSystem private (
sinks.foreach(_.start)
}
+ // Same as start but this method only registers sinks
Review comment:
Just to close the loop here: I like the extra flag to `start` instead of the
separate method.
As for AM vs. driver, the way I understand things, in cluster mode, there
will be two `MetricSystem` instances - one for the AM and one for the driver,
so you shouldn't lose any driver metrics.
JVM metrics for the client-mode AM can be interesting, but that's generally
not a source of problems that I've noticed, so we can probably punt on it for
now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> YARN applicationMaster metrics should not register static and JVM metrics
> -------------------------------------------------------------------------
>
> Key: SPARK-25277
> URL: https://issues.apache.org/jira/browse/SPARK-25277
> Project: Spark
> Issue Type: Bug
> Components: YARN
> Affects Versions: 2.4.0
> Reporter: Luca Canali
> Priority: Minor
>
> YARN applicationMaster metrics registration introduced in SPARK-24594 causes
> further registration of static metrics (Codegenerator and
> HiveExternalCatalog) and of JVM metrics, which I believe do not belong in
> this context.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
