[
https://issues.apache.org/jira/browse/SPARK-26337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16718037#comment-16718037
]
ASF GitHub Bot commented on SPARK-26337:
----------------------------------------
dongjoon-hyun commented on a change in pull request #23284:
[SPARK-26337][SQL][TEST] Add benchmark for LongToUnsafeRowMap
URL: https://github.com/apache/spark/pull/23284#discussion_r240799221
##########
File path: sql/core/benchmarks/HashedRelationMetricsBenchmark-results.txt
##########
@@ -6,6 +6,6 @@ Java HotSpot(TM) 64-Bit Server VM 1.8.0_181-b13 on Mac OS X
10.13.6
Intel(R) Core(TM) i7-7700HQ CPU @ 2.80GHz
LongToUnsafeRowMap metrics: Best/Avg Time(ms) Rate(M/s) Per
Row(ns) Relative
------------------------------------------------------------------------------------------------
-LongToUnsafeRowMap 1265 / 1336 0.4
2530.5 1.0X
+LongToUnsafeRowMap 234 / 315 2.1
467.3 1.0X
Review comment:
Yep. It's a clear reason to have this benchmark
(https://github.com/apache/spark/pull/23284/commits/723b27ce55770f5846d4244377b37f66f2f9ad60)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add benchmark for LongToUnsafeRowMap
> ------------------------------------
>
> Key: SPARK-26337
> URL: https://issues.apache.org/jira/browse/SPARK-26337
> Project: Spark
> Issue Type: Test
> Components: SQL
> Affects Versions: 3.0.0
> Reporter: Liang-Chi Hsieh
> Priority: Major
>
> Regarding the performance issue of SPARK-26155, I think it is better to add a
> benchmark for LongToUnsafeRowMap which is the root cause of performance
> regression. It can be easier to show performance difference between different
> metric implementation in LongToUnsafeRowMap.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
