[
https://issues.apache.org/jira/browse/SPARK-26243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16722716#comment-16722716
]
ASF GitHub Bot commented on SPARK-26243:
----------------------------------------
cloud-fan opened a new pull request #23329: [SPARK-26243][SQL][followup] fix
code style issues in TimestampFormatter.scala
URL: https://github.com/apache/spark/pull/23329
## What changes were proposed in this pull request?
1. rename `FormatterUtils` to `BaseDateTimeFormatter`, and make
`TimestampFormatter` and `DateFormatter` extend it
2. rename the name from `TimestampFormatter.scala` to
`BaseDateTimeFormatter.scala`
3. mark some methods as private
4. add `override` to some methods
## How was this patch tested?
existing tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Use java.time API for parsing timestamps and dates from JSON
> ------------------------------------------------------------
>
> Key: SPARK-26243
> URL: https://issues.apache.org/jira/browse/SPARK-26243
> Project: Spark
> Issue Type: Improvement
> Components: SQL
> Affects Versions: 2.4.0
> Reporter: Maxim Gekk
> Assignee: Maxim Gekk
> Priority: Major
> Fix For: 3.0.0
>
>
> Currently, CSV datasource uses Apache FastDateFormat with a few fallbacks for
> parsing values of TimestampType and DateType. The result of parsing is an
> instance of java.util.Date/Timestamp which represents a specific instant in
> time, with millisecond precision. The tickets aims to switch on Java 8 API -
> java.time which allow parsing with nanoseconds precision.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
