[
https://issues.apache.org/jira/browse/SPARK-26255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16723213#comment-16723213
]
ASF GitHub Bot commented on SPARK-26255:
----------------------------------------
asfgit closed pull request #23312: [SPARK-26255][YARN] Apply user provided UI
filters to SQL tab in yarn mode
URL: https://github.com/apache/spark/pull/23312
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/resource-managers/yarn/src/main/scala/org/apache/spark/scheduler/cluster/YarnSchedulerBackend.scala
b/resource-managers/yarn/src/main/scala/org/apache/spark/scheduler/cluster/YarnSchedulerBackend.scala
index 67c36aac49266..1289d4be79ea4 100644
---
a/resource-managers/yarn/src/main/scala/org/apache/spark/scheduler/cluster/YarnSchedulerBackend.scala
+++
b/resource-managers/yarn/src/main/scala/org/apache/spark/scheduler/cluster/YarnSchedulerBackend.scala
@@ -168,8 +168,10 @@ private[spark] abstract class YarnSchedulerBackend(
filterName != null && filterName.nonEmpty &&
filterParams != null && filterParams.nonEmpty
if (hasFilter) {
+ // SPARK-26255: Append user provided filters(spark.ui.filters) with yarn
filter.
+ val allFilters = filterName + "," + conf.get("spark.ui.filters", "")
logInfo(s"Add WebUI Filter. $filterName, $filterParams, $proxyBase")
- conf.set("spark.ui.filters", filterName)
+ conf.set("spark.ui.filters", allFilters)
filterParams.foreach { case (k, v) =>
conf.set(s"spark.$filterName.param.$k", v) }
scheduler.sc.ui.foreach { ui => JettyUtils.addFilters(ui.getHandlers,
conf) }
}
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Custom error/exception is not thrown for the SQL tab when UI filters are
> added in spark-sql launch
> --------------------------------------------------------------------------------------------------
>
> Key: SPARK-26255
> URL: https://issues.apache.org/jira/browse/SPARK-26255
> Project: Spark
> Issue Type: Bug
> Components: SQL, Web UI
> Affects Versions: 2.3.2
> Environment: 【Test Environment】：
> Server OS :-SUSE
> No. of Cluster Node:-3
> Spark Version:- 2.3.2
> Hadoop Version:-3.1
> Reporter: Sushanta Sen
> Assignee: Chakravarthi
> Priority: Major
> Fix For: 3.0.0
>
> Attachments: command.png, logs_before_fix.png, ui_befofre_fix.png
>
>
> 【Detailed description】：Custom error is not thrown for the SQL tab when UI
> filters are added in spark-sql launch
> 【Precondition】：
> 1.Cluster is up and running【Test step】：
> 1. Launch spark sql as below:
> [spark-sql --master yarn --conf
> spark.ui.filters=org.apache.hadoop.security.authentication.server.AuthenticationFilter
> --conf
> spark.org.apache.hadoop.security.authentication.server.AuthenticationFilter.params="type=simple"]
> 2. Go to Yarn application list UI link
> 3. Launch the application master for the Spark-SQL app ID
> 4. It will display an error
> 5. Append /executors, /stages, /jobs, /environment, /SQL
> 【Expect Output】：An error should be displayed "An error has occurred. Please
> check for all the TABS
> 【Actual Output】：The error message is displayed for all the tabs except SQL
> tab .
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
