[
https://issues.apache.org/jira/browse/SPARK-26394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16724325#comment-16724325
]
ASF GitHub Bot commented on SPARK-26394:
----------------------------------------
srowen closed pull request #23346: [SPARK-26394][core] Fix annotation error for
Utils.timeStringAsMs
URL: https://github.com/apache/spark/pull/23346
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/core/src/main/scala/org/apache/spark/util/Utils.scala
b/core/src/main/scala/org/apache/spark/util/Utils.scala
index c8b148be84536..8f86b472b9373 100644
--- a/core/src/main/scala/org/apache/spark/util/Utils.scala
+++ b/core/src/main/scala/org/apache/spark/util/Utils.scala
@@ -1085,7 +1085,7 @@ private[spark] object Utils extends Logging {
}
/**
- * Convert a time parameter such as (50s, 100ms, or 250us) to microseconds
for internal use. If
+ * Convert a time parameter such as (50s, 100ms, or 250us) to milliseconds
for internal use. If
* no suffix is provided, the passed number is assumed to be in ms.
*/
def timeStringAsMs(str: String): Long = {
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Annotation error for Utils.timeStringAsMs
> -----------------------------------------
>
> Key: SPARK-26394
> URL: https://issues.apache.org/jira/browse/SPARK-26394
> Project: Spark
> Issue Type: Bug
> Components: Documentation, Spark Core
> Affects Versions: 2.4.0
> Reporter: Jackey Lee
> Assignee: Jackey Lee
> Priority: Trivial
> Fix For: 2.3.3, 2.4.1, 3.0.0
>
>
> Utils.timeStringAsMs() is parsing time to milliseconds, but in annotation, it
> says "Convert a time parameter such as (50s, 100ms, or 250us) to microseconds
> for internal use."
> Thus, microseconds should be changed to milliseconds.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
