[ 
https://issues.apache.org/jira/browse/SPARK-26223?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16727201#comment-16727201
 ] 

ASF GitHub Bot commented on SPARK-26223:
----------------------------------------

xuanyuanking opened a new pull request #23371: [SPARK-26223][SQL] Track 
metastore operation time in scan node
URL: https://github.com/apache/spark/pull/23371
 
 
   ## What changes were proposed in this pull request?
   
   As the comment in 
[SPARK-26223](https://issues.apache.org/jira/browse/SPARK-26223?focusedCommentId=16723111&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16723111),
 track all metastore operation time in scan node and show the duration in 
metrics as well as the timeline when hover. The mainly changes including:
   - Add `metastoreOpsPhaseSummaries` in CatalogTable param list for recording 
all timeline between the table and the metastore.
   - Create phase summaries in all scenarios described in Jira and memorize 
them into `metastoreOpsPhaseSummaries`.
   - Display support and driver metrics updating for metastore operations.
   
   ## How was this patch tested?
   Add UT in SQLMetricsSuite.
   Manually test and check UI:
   
   |             Scenario            | UI |
   |:-------------------------------:|----|
   | FileSourceScanExec with partition pruning 
|![image](https://user-images.githubusercontent.com/4833765/50370288-04547300-05df-11e9-9bab-549c89d180fa.png)|
   | HiveTableScanExec 
|![image](https://user-images.githubusercontent.com/4833765/50370268-ae7fcb00-05de-11e9-9f4c-eeb8e3e8f2d1.png)|
   | FileSourceScanExec with RelationConversion for hive table 
|![image](https://user-images.githubusercontent.com/4833765/50370310-5e553880-05df-11e9-98af-766248504fc8.png)|
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Scan: track metastore operation time
> ------------------------------------
>
>                 Key: SPARK-26223
>                 URL: https://issues.apache.org/jira/browse/SPARK-26223
>             Project: Spark
>          Issue Type: Sub-task
>          Components: SQL
>    Affects Versions: 2.4.0
>            Reporter: Reynold Xin
>            Priority: Major
>
> The Scan node should report how much time it spent in metastore operations. 
> Similar to file listing, would be great to also report start and end time for 
> constructing a timeline.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org

Reply via email to