[ https://issues.apache.org/jira/browse/SPARK-26505?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Devin Boyer updated SPARK-26505: -------------------------------- Description: This change fell out of the review of [https://github.com/apache/spark/pull/20658,] which is the implementation of https://issues.apache.org/jira/browse/SPARK-23488. The Scala Catalog class [Function|http://spark.apache.org/docs/latest/api/scala/index.html#org.apache.spark.sql.catalog.Function] contains a `database` attribute, while the [Python version|https://github.com/apache/spark/blob/v2.4.0/python/pyspark/sql/catalog.py#L32] does not. To be consistent, it would likely be best to add the `database` attribute to the Python class. This would be a breaking API change, though (as discussed in [this PR comment|[https://github.com/apache/spark/pull/20658#issuecomment-368561007]]), so it would have to be made for Spark 3.0.0, the next major version where breaking API changes can occur. was: This change fell out of the review of [https://github.com/apache/spark/pull/20658,] which is the implementation of https://issues.apache.org/jira/browse/SPARK-23488. The Scala Catalog class [Function|http://spark.apache.org/docs/latest/api/scala/index.html#org.apache.spark.sql.catalog.Function] contains a `database` attribute, while the [Python version|https://github.com/apache/spark/blob/v2.4.0/python/pyspark/sql/catalog.py#L32] does not. To be consistent, it would likely be best to add the `database` attribute to the Python class. This would be a breaking API change, though (as discussed in [this PR comment|[https://github.com/apache/spark/pull/20658#issuecomment-368561007]|https://github.com/apache/spark/pull/20658#issuecomment-368561007]), so it would have to be made for Spark 3.0.0, the next major version where breaking API changes can occur. > Catalog class Function is missing "database" field > -------------------------------------------------- > > Key: SPARK-26505 > URL: https://issues.apache.org/jira/browse/SPARK-26505 > Project: Spark > Issue Type: Improvement > Components: PySpark > Affects Versions: 2.4.0 > Reporter: Devin Boyer > Priority: Minor > > This change fell out of the review of > [https://github.com/apache/spark/pull/20658,] which is the implementation of > https://issues.apache.org/jira/browse/SPARK-23488. The Scala Catalog class > [Function|http://spark.apache.org/docs/latest/api/scala/index.html#org.apache.spark.sql.catalog.Function] > contains a `database` attribute, while the [Python > version|https://github.com/apache/spark/blob/v2.4.0/python/pyspark/sql/catalog.py#L32] > does not. > > To be consistent, it would likely be best to add the `database` attribute to > the Python class. This would be a breaking API change, though (as discussed > in [this PR > comment|[https://github.com/apache/spark/pull/20658#issuecomment-368561007]]), > so it would have to be made for Spark 3.0.0, the next major version where > breaking API changes can occur. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org For additional commands, e-mail: issues-h...@spark.apache.org