[ https://issues.apache.org/jira/browse/SPARK-27193?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
wuyi updated SPARK-27193: ------------------------- Description: when enable `spark.sql.codegen.comments`, there will be multiple comment lines. However, CodeFormatter can not handle multi comment lines currently: Generated code: /* 001 */ public Object generate(Object[] references) { /* 002 */ return new GeneratedIteratorForCodegenStage1(references); /* 003 */ } /* 004 */ /* 005 */ /** \* Codegend pipeline for stage (id=1) \* *(1) Project [(id#0L + 1) AS (id + 1)#3L] \* +- *(1) Filter (id#0L = 1) \* +- *(1) Range (0, 10, step=1, splits=4) \*/ /* 006 */ // codegenStageId=1 /* 007 */ final class GeneratedIteratorForCodegenStage1 extends org.apache.spark.sql.execution.BufferedRowIterator { was: when enable `spark.sql.codegen.comments`, there will be multiple comment lines. However, CodeFormatter can not handle multi comment lines currently: Generated code: /* 001 */ public Object generate(Object[] references) { /* 002 */ return new GeneratedIteratorForCodegenStage1(references); /* 003 */ } /* 004 */ /* 005 */ /** * Codegend pipeline for stage (id=1) * *(1) Project [(id#0L + 1) AS (id + 1)#3L] * +- *(1) Filter (id#0L = 1) * +- *(1) Range (0, 10, step=1, splits=4) */ /* 006 */ // codegenStageId=1 /* 007 */ final class GeneratedIteratorForCodegenStage1 extends org.apache.spark.sql.execution.BufferedRowIterator { > CodeFormatter should format multi comment lines correctly > --------------------------------------------------------- > > Key: SPARK-27193 > URL: https://issues.apache.org/jira/browse/SPARK-27193 > Project: Spark > Issue Type: Improvement > Components: SQL > Affects Versions: 2.4.0 > Reporter: wuyi > Priority: Major > > when enable `spark.sql.codegen.comments`, there will be multiple comment > lines. However, CodeFormatter can not handle multi comment lines currently: > > Generated code: > /* 001 */ public Object generate(Object[] references) { > /* 002 */ return new GeneratedIteratorForCodegenStage1(references); > /* 003 */ } > /* 004 */ > /* 005 */ /** > \* Codegend pipeline for stage (id=1) > \* *(1) Project [(id#0L + 1) AS (id + 1)#3L] > \* +- *(1) Filter (id#0L = 1) > \* +- *(1) Range (0, 10, step=1, splits=4) > \*/ > /* 006 */ // codegenStageId=1 > /* 007 */ final class GeneratedIteratorForCodegenStage1 extends > org.apache.spark.sql.execution.BufferedRowIterator { -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org For additional commands, e-mail: issues-h...@spark.apache.org