[
https://issues.apache.org/jira/browse/SPARK-27220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16797428#comment-16797428
]
Ajith S commented on SPARK-27220:
---------------------------------
# About making *currentExecutorIdCounter* datatype consistent, Yes,
*currentExecutorIdCounter* is int initially in *CoarseGrainedSchedulerBackend*,
but when it expects *RegisterExecutor* it expects String which makes it
confusing. ** Also *CoarseGrainedExecutorBackend* fires *RegisterExecutor*
incase of yarn,mesos with executorId as String
# About moving out *currentExecutorIdCounter* from
*CoarseGrainedSchedulerBackend,* this i am unsure as
*CoarseGrainedSchedulerBackend* is just offering a mechanism to maintain
executor ids which yarn is just reusing (But i see mesos ignores it completely
and instead uses mesosTaskId, so makes sense of moving
*currentExecutorIdCounter* out to yarn)
cc [~srowen] [~dongjoon] [~hyukjin.kwon] any thoughts.?
> Remove Yarn specific leftover from CoarseGrainedSchedulerBackend
> ----------------------------------------------------------------
>
> Key: SPARK-27220
> URL: https://issues.apache.org/jira/browse/SPARK-27220
> Project: Spark
> Issue Type: Task
> Components: Spark Core, YARN
> Affects Versions: 2.0.2, 2.1.3, 2.2.3, 2.3.3, 2.4.0
> Reporter: Jacek Lewandowski
> Priority: Minor
>
> {{CoarseGrainedSchedulerBackend}} has the following field:
> {code:scala}
> // The num of current max ExecutorId used to re-register appMaster
> @volatile protected var currentExecutorIdCounter = 0
> {code}
> which is then updated:
> {code:scala}
> case RegisterExecutor(executorId, executorRef, hostname, cores,
> logUrls) =>
> ...
> // This must be synchronized because variables mutated
> // in this block are read when requesting executors
> CoarseGrainedSchedulerBackend.this.synchronized {
> executorDataMap.put(executorId, data)
> if (currentExecutorIdCounter < executorId.toInt) {
> currentExecutorIdCounter = executorId.toInt
> }
> ...
> {code}
> However it is never really used in {{CoarseGrainedSchedulerBackend}}. Its
> only usage is in Yarn-specific code. It should be moved to Yarn then because
> {{executorId}} is a {{String}} and there are really no guarantees that it is
> always an integer. It was introduced in SPARK-12864
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
