[ https://issues.apache.org/jira/browse/SPARK-18262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16802719#comment-16802719 ]
Yuming Wang commented on SPARK-18262: ------------------------------------- [~srowen] I'm not sure do we need exclude {{org.json#json}} from [https://github.com/apache/spark/blob/master/sql/hive/src/main/scala/org/apache/spark/sql/hive/client/package.scala|https://github.com/apache/spark/blob/master/sql/hive/src/main/scala/org/apache/spark/sql/hive/client/package.scala#L20] Run {{HiveSparkSubmitSuite}} to reproduce:: {code:java} HiveSparkSubmitSuite.test("SPARK-8020: set sql conf in spark conf") { val unusedJar = TestUtils.createJarWithClasses(Seq.empty) val args = Seq( "--class", SparkSQLConfTest.getClass.getName.stripSuffix("$"), "--name", "SparkSQLConfTest", "--master", "local-cluster[2,1,1024]", "--conf", "spark.ui.enabled=false", "--conf", "spark.master.rest.enabled=false", "--conf", "spark.sql.hive.metastore.version=0.12", "--conf", "spark.sql.hive.metastore.jars=maven", "--driver-java-options", "-Dderby.system.durability=test", unusedJar.toString) runSparkSubmit(args) } {code} {noformat} ... 2019-03-04 11:51:02.184 - stderr> found com.google.protobuf#protobuf-java;2.4.1 in central 2019-03-04 11:51:02.207 - stderr> found org.iq80.snappy#snappy;0.2 in user-list 2019-03-04 11:51:02.212 - stderr> found org.json#json;20090211 in user-list 2019-03-04 11:51:02.234 - stderr> found commons-configuration#commons-configuration;1.6 in user-list ... {noformat} > JSON.org license is now CatX > ---------------------------- > > Key: SPARK-18262 > URL: https://issues.apache.org/jira/browse/SPARK-18262 > Project: Spark > Issue Type: Bug > Reporter: Sean Busbey > Assignee: Sean Owen > Priority: Blocker > Fix For: 2.1.0 > > > per [update resolved legal|http://www.apache.org/legal/resolved.html#json]: > {quote} > CAN APACHE PRODUCTS INCLUDE WORKS LICENSED UNDER THE JSON LICENSE? > No. As of 2016-11-03 this has been moved to the 'Category X' license list. > Prior to this, use of the JSON Java library was allowed. See Debian's page > for a list of alternatives. > {quote} > I'm not actually clear if Spark is using one of the JSON.org licensed > libraries. As of current master (dc4c6009) the java library gets called out > in the [NOTICE file for our source > repo|https://github.com/apache/spark/blob/dc4c60098641cf64007e2f0e36378f000ad5f6b1/NOTICE#L424] > but: > 1) It doesn't say where in the source > 2) the given url is 404 (http://www.json.org/java/index.html) > 3) It doesn't actually say in the NOTICE what license the inclusion is under > 4) the JSON.org license for the java {{org.json:json}} artifact (what the > blurb in #2 is usually referring to) doesn't show up in our LICENSE file, nor > in the {{licenses/}} directory > 5) I don't see a direct reference to the {{org.json:json}} artifact in our > poms. > So maybe it's just coming in transitively and we can exclude it / ping > whoever is bringing it in? -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org For additional commands, e-mail: issues-h...@spark.apache.org