[ 
https://issues.apache.org/jira/browse/SPARK-27367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16821653#comment-16821653
 ] 

Liang-Chi Hsieh edited comment on SPARK-27367 at 4/19/19 4:32 AM:
------------------------------------------------------------------

I do upgrade it in local. But seems the performance improvement isn't so 
obvious. Maybe the optimization is only significant on larger bitmap. I'm not 
sure if in Spark we will have large bitmap that can take advantage of this 
optimization.

I compare 0.7.45 (used in current Spark) and 0.8.1 (latest release), except for 
serde to bytebuffer, I didn't see other noticeable commits.

So, do we still want to upgrade to 0.8.1? If so, I can make a PR.

 


was (Author: viirya):
I do upgrade it in local. But seems the performance improvement isn't so 
obvious. Maybe the optimization is only significant on larger bitmap. I'm not 
sure if in Spark we will have large bitmap that can take advantage of this 
optimization.

I compare 0.7.45 (used in current master) and 0.8.1 (latest release), except 
for serde to bytebuffer, I didn't see other noticeable commits.

So, do we still want to upgrade to 0.8.1? If so, I can make a PR.

 

> Faster RoaringBitmap Serialization with v0.8.0
> ----------------------------------------------
>
>                 Key: SPARK-27367
>                 URL: https://issues.apache.org/jira/browse/SPARK-27367
>             Project: Spark
>          Issue Type: Improvement
>          Components: Spark Core
>    Affects Versions: 3.0.0
>            Reporter: Imran Rashid
>            Priority: Major
>
> RoaringBitmap 0.8.0 adds faster serde, but also requires us to change how we 
> call the serde routines slightly to take advantage of it.  This is probably a 
> worthwhile optimization as the every shuffle map task with a large # of 
> partitions generates these bitmaps, and the driver especially has to 
> deserialize many of these messages.
> See 
> * https://github.com/apache/spark/pull/24264#issuecomment-479675572
> * https://github.com/RoaringBitmap/RoaringBitmap/pull/325
> * https://github.com/RoaringBitmap/RoaringBitmap/issues/319



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org

Reply via email to