[
https://issues.apache.org/jira/browse/SPARK-30869?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17042102#comment-17042102
]
YoungGyu Chun edited comment on SPARK-30869 at 2/21/20 6:56 PM:
----------------------------------------------------------------
I closed Pull Request #27661 and won't be working on this as it's duplicate
work of #27618.
was (Author: younggyuchun):
I closed Pull Request [#27661|[https://github.com/apache/spark/pull/27661]]
and won't be working on this as it's duplicate work of #27618.
> Convert dates to/from timestamps in microseconds precision
> ----------------------------------------------------------
>
> Key: SPARK-30869
> URL: https://issues.apache.org/jira/browse/SPARK-30869
> Project: Spark
> Issue Type: Improvement
> Components: SQL
> Affects Versions: 3.0.0
> Reporter: Maxim Gekk
> Priority: Minor
>
> Currently, Spark converts dates to/from "timestamp" in millisecond precision
> but internally Catalyst's TimestampType values are stored as microseconds
> since epoch. When such conversion is needed in other date-timestamp functions
> like DateTimeUtils.monthsBetween, the function has to convert microseconds to
> milliseconds and then to days, see
> https://github.com/apache/spark/blob/06217cfded8d32962e7c54c315f8e684eb9f0999/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala#L577-L580
> which just brings additional overhead w/o any benefits.
> In later versions, it makes sense because milliseconds can be passed to
> TimeZone.getOffset but recently Spark switched to Java 8 time API and ZoneId.
> And supporting conversions to milliseconds are not needed any more.
> The ticket aims to replace millisToDays by microsToDays, and daysToMillis by
> daysToMicros in DateTimeUtils.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org
