[ https://issues.apache.org/jira/browse/SPARK-30765?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hyukjin Kwon resolved SPARK-30765. ---------------------------------- Fix Version/s: 3.1.0 Resolution: Fixed Issue resolved by pull request 27511 [https://github.com/apache/spark/pull/27511] > Refine baes class abstraction code style > ---------------------------------------- > > Key: SPARK-30765 > URL: https://issues.apache.org/jira/browse/SPARK-30765 > Project: Spark > Issue Type: Improvement > Components: SQL > Affects Versions: 3.1.0 > Reporter: Xin Wu > Assignee: Xin Wu > Priority: Major > Fix For: 3.1.0 > > > When doing base operator abstraction work, I found there are still some code > snippet is inconsistent with other abstraction code style. > > Case 1, override keyword missed for some fields in derived classes. The > compiler will not capture it if we rename some fields in the future. > [https://github.com/apache/spark/pull/27368#discussion_r376694045] > > > Case 2, inconsistent abstract class definition. The updated style will > simplify derived class definition. > [https://github.com/apache/spark/pull/27368#discussion_r375061952] > -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org For additional commands, e-mail: issues-h...@spark.apache.org