Ryan Williams created SPARK-5416:
------------------------------------

             Summary: Initialize Executor.threadPool before ExecutorSource
                 Key: SPARK-5416
                 URL: https://issues.apache.org/jira/browse/SPARK-5416
             Project: Spark
          Issue Type: Improvement
          Components: Spark Core
    Affects Versions: 1.2.0
            Reporter: Ryan Williams
            Priority: Minor


I recently saw some NPEs from 
[{{ExecutorSource:44}}|https://github.com/apache/spark/blob/0497ea51ac345f8057d222a18dbbf8eae78f5b92/core/src/main/scala/org/apache/spark/executor/ExecutorSource.scala#L44]
 in the first couple seconds of my executors' being initialized.

I think that {{ExecutorSource}} was trying to report these metrics before its 
threadpool was initialized; there are a few LoC between the source being 
registered 
([Executor.scala:82|https://github.com/apache/spark/blob/0497ea51ac345f8057d222a18dbbf8eae78f5b92/core/src/main/scala/org/apache/spark/executor/Executor.scala#L82])
 and the threadpool being initialized 
([Executor.scala:106|https://github.com/apache/spark/blob/0497ea51ac345f8057d222a18dbbf8eae78f5b92/core/src/main/scala/org/apache/spark/executor/Executor.scala#L106]).

We should initialize the threapool before the ExecutorSource is registered.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org

Reply via email to