Srinivas Rishindra Pothireddi created SPARK-31377:
-----------------------------------------------------

             Summary: Add missing unit tests for "number of output rows" metric 
for joins in SQLMetricsSuite
                 Key: SPARK-31377
                 URL: https://issues.apache.org/jira/browse/SPARK-31377
             Project: Spark
          Issue Type: Improvement
          Components: SQL, Tests
    Affects Versions: 3.0.0
            Reporter: Srinivas Rishindra Pothireddi


For some combinations of join algorithm and join types there are no unit tests 
for the "number of output rows" metric.

For Inner join and BroadcastHashJoin there is code in unit tests with code 
generation enabled. There are no tests for the "number of output rows" metric 
with code generation disabled.

A list of missing unit tests include the following.
 * SortMergeJoin: ExistenceJoin
 * ShuffledHashJoin: OuterJoin, ReftOuter, RightOuter, LeftAnti, LeftSemi, 
ExistenseJoin
 * BroadcastNestedLoopJoin: RightOuter, ExistenceJoin, InnerJoin
 * BroadcastHashJoin: LeftAnti, ExistenceJoin
 * All the join types for SortMergeJoin and BroadcastHashJoin with code 
generation turned off.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org
For additional commands, e-mail: issues-h...@spark.apache.org

Reply via email to