[ https://issues.apache.org/jira/browse/SPARK-31579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17099579#comment-17099579 ]
Maxim Gekk commented on SPARK-31579: ------------------------------------ [~suddhuASF] The replace floorDiv by / is trivial. Please, write a code which proofs that first of all, and post it here in a comment. /cc [~cloud_fan] [~hyukjin.kwon] The code should go over all available time zones with the step of 1 hours + jitter of a few minutes. > Replace floorDiv by / in localRebaseGregorianToJulianDays() > ----------------------------------------------------------- > > Key: SPARK-31579 > URL: https://issues.apache.org/jira/browse/SPARK-31579 > Project: Spark > Issue Type: Improvement > Components: SQL > Affects Versions: 3.1.0 > Reporter: Maxim Gekk > Priority: Minor > Labels: starter > > Most likely utcCal.getTimeInMillis % MILLIS_PER_DAY == 0 but need to check > that for all available time zones in the range of [0001, 2100] years with the > step of 1 hour or maybe smaller. If this hypothesis is confirmed, floorDiv > can be replaced by /, and this should improve performance of > RebaseDateTime.localRebaseGregorianToJulianDays. -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org For additional commands, e-mail: issues-h...@spark.apache.org