jiaan.geng created SPARK-31846: ---------------------------------- Summary: DAGSchedulerSuite: For the pattern of cancel + assert, extract the general method Key: SPARK-31846 URL: https://issues.apache.org/jira/browse/SPARK-31846 Project: Spark Issue Type: Sub-task Components: Spark Core Affects Versions: 3.1.0 Reporter: jiaan.geng
DAGSchedulerSuite exists many test case(e.g. trivial job cancellation | job cancellation no-kill backend) contains the pattern of cancel + assert, such as: {code:java} test("trivial job cancellation") { val rdd = new MyRDD(sc, 1, Nil) val jobId = submit(rdd, Array(0)) cancel(jobId) assert(failure.getMessage === s"Job $jobId cancelled ") assert(sparkListener.failedStages === Seq(0)) assertDataStructuresEmpty() } {code} We should extract the general method like cancelAndCheck(jobId: Int, predicate) -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@spark.apache.org For additional commands, e-mail: issues-h...@spark.apache.org